Skip to content

TD-5636 Resolved the not found error from the end point #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TD-5636 Resolved the not found error from the end point #3394

wants to merge 1 commit into from

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-5636

Description

Corrected the endpoint name that was causing the “Not Found” error

Screenshots

image ----- ### Developer checks (Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

rshrirohit
rshrirohit requested changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@rshrirohit rshrirohit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I read in the Jira ticket, this was about adding duplicate resources. But the changes here seem like solving some other 'not found' error? Can you please elaborate on how these changes solve the original scope of the ticket?
Edit: I saw that it was mentioned in the jira ticket comment. So this is ok. But still the original scope of ticket is not handled I think.

@sherif-olaboye
Copy link
Contributor Author

As I read in the Jira ticket, this was about adding duplicate resources. But the changes here seem like solving some other 'not found' error? Can you please elaborate on how these changes solve the original scope of the ticket? Edit: I saw that it was mentioned in the jira ticket comment. So this is ok. But still the original scope of ticket is not handled I think.

@sherif-olaboye
Copy link
Contributor Author

As I read in the Jira ticket, this was about adding duplicate resources. But the changes here seem like solving some other 'not found' error? Can you please elaborate on how these changes solve the original scope of the ticket? Edit: I saw that it was mentioned in the jira ticket comment. So this is ok. But still the original scope of ticket is not handled I think.

The initial bug with adding duplicate resources has been fixed. However, when Seema tried to test the fix, she encountered a 'Not Found' error while adding resources. This PR addresses and fixes that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshrirohit rshrirohit rshrirohit requested changes

@kevwhitt-hee kevwhitt-hee Awaiting requested review from kevwhitt-hee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sherif-olaboye @rshrirohit